Fix longtask layout tests This CL fixes the 3 remaining tests in longtask-timing that Timeout. The iframes are added from script instead of html because this seems to make frame attribution easier. The cross-origin tests are changed to use the sandbox property of iframes instead of changing the src. Bug: 754819 Change-Id: I1dfd0e3d7c1d2f29feb0eba5e98b683faa5ab44c Reviewed-on: https://chromium-review.googlesource.com/798155 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Shubhie Panicker <panicker@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521388} diff --git a/longtask-timing/longtask-in-sibling-iframe.html b/longtask-timing/longtask-in-sibling-iframe.html index 9f53621..d463810 100644 --- a/longtask-timing/longtask-in-sibling-iframe.html +++ b/longtask-timing/longtask-in-sibling-iframe.html
@@ -9,21 +9,25 @@ <script> async_test(t => { window.addEventListener('message', t.step_func(e => { - assert_equals(e.data, 'longtask+same-origin+script+child-iframe-id+' + - 'child-iframe-name+resources/subframe-with-longtask.html'); + assert_equals(e.data['entryType'], 'longtask'); + assert_equals(e.data['frame-attribution'], 'same-origin'); + assert_equals(e.data['task-attribution'], 'script'); + assert_equals(e.data['containerId'], 'longtask-iframe-id'); + assert_equals(e.data['containerName'], 'longtask-iframe-name'); + assert_equals(e.data['containerSrc'], 'resources/subframe-with-longtask.html'); t.done(); })); -}, 'Performance longtask entries in parent are observable in child iframe.'); -</script> + const observingFrame = document.createElement('iframe'); + observingFrame.id = 'observing-iframe-id'; + observingFrame.name = 'observing-iframe-name'; + document.body.appendChild(observingFrame); + observingFrame.src = 'resources/subframe-observing-longtask.html' -<iframe src="resources/subframe-observing-longtask.html"></iframe> - -<script> - /* Create an iframe that generates a long task. */ - const iframe = document.createElement('iframe'); - iframe.id = 'child-iframe-id'; - iframe.name = 'child-iframe-name'; - document.body.appendChild(iframe); - iframe.src = 'resources/subframe-with-longtask.html' + const longtaskFrame = document.createElement('iframe'); + longtaskFrame.id = 'longtask-iframe-id'; + longtaskFrame.name = 'longtask-iframe-name'; + document.body.appendChild(longtaskFrame); + longtaskFrame.src = 'resources/subframe-with-longtask.html' +}, 'Performance longtask entries are observable in sibling iframe.'); </script> </body> 